From: Zhiyi Zhang Subject: Re: [PATCH 1/5] dxgi: Implement dxgi_factory_MakeWindowAssociation(). Message-Id: <1dd9ab9e-2efb-1540-3463-9c6a9ef31ddb@codeweavers.com> Date: Wed, 24 Apr 2019 20:27:13 +0800 In-Reply-To: References: <23f93edf-b58f-feef-4611-31d470281cb5@codeweavers.com> <657aebe3-2072-b846-3f11-3b6a07cb7889@codeweavers.com> On 4/24/19 6:48 PM, Henri Verbeet wrote: > On Wed, 24 Apr 2019 at 07:15, Zhiyi Zhang wrote: >> On 4/24/19 1:54 AM, Henri Verbeet wrote: >>> Would it make sense to adapt the existing wined3d_wndproc_table in >>> wined3d to handle DXGI window associations? >>> >> I am sure it will make more sense. If we use wined3d_wndproc_table then it doesn't explain Sorry, typo. I shouldn't get up so early and reply emails. I meant I am *not* sure it will make more sense >> why set up a hook to ignore WM_SYSKEYDOWN breaks Alt+Enter, or why SendMessage(WM_SYSKEYDOWN) >> don't trigger Alt+Enter while PostMessage(WM_SYSKEYDOWN) does. It seems more accurate to >> set up a hook to intercept message before GetMessage returns. >> >> Another thing may be of interest. Application doesn't receive a WM_SYSKEYDOWN(Alt+Enter) when Alt+Enter >> is pressed. > I'm not objecting to using hooks, although it would still be good to > have tests to validate that e.g. MakeWindowAssociation() or swapchain I'll add more tests. > creation doesn't change GWLP_WNDPROC on the window. It seems > undesirable though to track the window to swapchain/device association > in two different places, and to a lesser extent the same goes for > handling the events themselves. Right. It doesn't look nice this way. MakeWindowAssociation being in IDXGIFactory puzzles me at the very start. I haven't found a way for it to look nicer.