From: Zebediah Figura <z.figura12@gmail.com>
Subject: Re: [PATCH] qcap: Fix a COM reference leak in the audiorecord test.
Message-Id: <da02c93c-c665-2747-4201-adf7c3d6757b@gmail.com>
Date: Mon, 22 Apr 2019 15:36:14 -0500
In-Reply-To: <CAJm2B-nWtUNbaJ_Z+uRtX=oRXB50XUgrEGbdn071Ljb-Rm7H2Q@mail.gmail.com>
References: <CAJm2B-=m_9YuNxP8GNNMutvYoJkgg_cz8Kg1M8VL0eYYchyC5w@mail.gmail.com> <f451c987-0f83-5fa1-1642-fa9ca2886534@gmail.com> <CAJm2B-nWtUNbaJ_Z+uRtX=oRXB50XUgrEGbdn071Ljb-Rm7H2Q@mail.gmail.com>

On 4/22/19 1:06 PM, Damjan Jovanovic wrote:
> 
> 
> On Mon, Apr 22, 2019 at 7:51 PM Zebediah Figura <z.figura12@gmail.com 
> <mailto:z.figura12@gmail.com>> wrote:
> 
>     On 04/22/2019 02:38 AM, Damjan Jovanovic wrote:
>      > Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com
>     <mailto:damjan.jov@gmail.com>>
>      > ---
>      >  dlls/qcap/tests/audiorecord.c | 5 ++++-
>      >  1 file changed, 4 insertions(+), 1 deletion(-)
>      >
>      >
>      >
>      >
> 
>     Thanks for finding the leak. "filter" can never be NULL at that point,
>     and we also want to test that we really are releasing the last
>     reference. I've sent an updated patch that addresses these.
> 
> 
> Pleasure.
> It can be NULL, if IMoniker_BindToObject() fails.
> 
> 
> 

IMoniker::BindToObject() shouldn't fail; that's checked above.