From: Damjan Jovanovic Subject: Re: [PATCH] qcap: Fix a COM reference leak in the audiorecord test. Message-Id: Date: Mon, 22 Apr 2019 20:06:26 +0200 In-Reply-To: References: On Mon, Apr 22, 2019 at 7:51 PM Zebediah Figura wrote: > On 04/22/2019 02:38 AM, Damjan Jovanovic wrote: > > Signed-off-by: Damjan Jovanovic > > --- > > dlls/qcap/tests/audiorecord.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > > > Thanks for finding the leak. "filter" can never be NULL at that point, > and we also want to test that we really are releasing the last > reference. I've sent an updated patch that addresses these. > > Pleasure. It can be NULL, if IMoniker_BindToObject() fails.


On Mon, Apr 22, 2019 at 7:51 PM Zebediah Figura <z.figura12@gmail.com> wrote:
On 04/22/2019 02:38 AM, Damjan Jovanovic wrote:
> Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
> ---
>  dlls/qcap/tests/audiorecord.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
>
>
>

Thanks for finding the leak. "filter" can never be NULL at that point,
and we also want to test that we really are releasing the last
reference. I've sent an updated patch that addresses these.


Pleasure.
It can be NULL, if IMoniker_BindToObject() fails.