From: Alexandre Julliard <julliard@winehq.org>
Subject: Re: [PATCH 1/2] server: Add default security descriptor ownership for processes.
Message-Id: <874l6qq7zf.fsf@wine>
Date: Mon, 22 Apr 2019 19:12:52 +0200
In-Reply-To: <20190417085332.1918-1-infyquest@gmail.com> (Vijay Kiran Kamuju's message of "Wed, 17 Apr 2019 10:53:31 +0200")
References: <20190417085332.1918-1-infyquest@gmail.com>

Vijay Kiran Kamuju <infyquest@gmail.com> writes:

> +static struct security_descriptor *process_get_sd( struct object *obj )
> +{
> +    static struct security_descriptor *key_default_sd;
> +
> +    if (obj->sd) return obj->sd;
> +
> +    if (!key_default_sd)
> +    {
> +        size_t users_sid_len = security_sid_len( security_domain_users_sid );
> +        size_t admins_sid_len = security_sid_len( security_builtin_admins_sid );
> +
> +        key_default_sd = mem_alloc( sizeof(*key_default_sd) + admins_sid_len + users_sid_len  );
> +        key_default_sd->control   = SE_DACL_PRESENT;
> +        key_default_sd->owner_len = admins_sid_len;
> +        key_default_sd->group_len = users_sid_len;
> +        key_default_sd->sacl_len  = 0;
> +        key_default_sd->dacl_len  = 0;
> +        memcpy( key_default_sd + 1, security_builtin_admins_sid, admins_sid_len );
> +        memcpy( (char *)(key_default_sd + 1) + admins_sid_len, security_domain_users_sid, users_sid_len );
> +    }
> +    return key_default_sd;

key_default_sd is clearly not the appropriate name here.

-- 
Alexandre Julliard
julliard@winehq.org