From: Paul Gofman <gofmanp@gmail.com>
Subject: Re: [PATCH] wined3d: Check GLSL version when using ARB_shader_bit_encoding with uvec4.
Message-Id: <db6ac374-38a8-2a3c-edf6-062840296aec@gmail.com>
Date: Fri, 19 Apr 2019 15:35:57 +0300
In-Reply-To: <CAOsNvwwhzz5eJoLfq8+-ZkEyDC5oz-ZbkEZFqQwa3en4x97o3w@mail.gmail.com>
References: <20190418170649.27930-1-gofmanp@gmail.com> <CAKF0LCVp8Cx-t-O4BeZH2sMNNOHTEfTJd_WdB3z8EzKV6wYe+Q@mail.gmail.com> <21120c18-061e-d959-16cf-df27fe6d2abb@gmail.com> <CAOsNvwxXG0VGBsO8bcq4DaEy-O5sR-LJVnjUA6WqESLMVaKiUg@mail.gmail.com> <a726081c-4861-43f5-a1c6-e485823ac995@gmail.com> <CAOsNvwwhzz5eJoLfq8+-ZkEyDC5oz-ZbkEZFqQwa3en4x97o3w@mail.gmail.com>

On 4/19/19 15:30, Henri Verbeet wrote:
> On Fri, 19 Apr 2019 at 16:38, Paul Gofman <gofmanp@gmail.com> wrote:
>> On 4/19/19 14:42, Henri Verbeet wrote:
>>
> That and "negative" values are the main issues I'd be potentially
> worried about, but at the same time I wouldn't expect drivers/hardware
> to go out of their way to distinguish between singned/unsigned here.
> We could also potentially switch between uvec4 and ivec4 based on
> whether we have GLSL 1.30 or not, but that may not offer any
> advantages in practice.

I will test this and change uints to ints whenever 
ARB_shader_bit_encoding is used then.