From: Paul Gofman <gofmanp@gmail.com>
Subject: Re: [PATCH] wined3d: Check GLSL version when using ARB_shader_bit_encoding with uvec4.
Message-Id: <21120c18-061e-d959-16cf-df27fe6d2abb@gmail.com>
Date: Fri, 19 Apr 2019 14:12:21 +0300
In-Reply-To: <CAKF0LCVp8Cx-t-O4BeZH2sMNNOHTEfTJd_WdB3z8EzKV6wYe+Q@mail.gmail.com>
References: <20190418170649.27930-1-gofmanp@gmail.com> <CAKF0LCVp8Cx-t-O4BeZH2sMNNOHTEfTJd_WdB3z8EzKV6wYe+Q@mail.gmail.com>

On 4/19/19 13:35, Józef Kucia wrote:
>
> I'm not sure but I think that it could be preferred to disable
> ARB_shader_bit_encoding when GLSL version < 1.30. We disable other
> extensions conditionally in wined3d_adapter_init_gl_caps(), e.g.
> ARB_shader_bit_encoding or ARB_shader_bit_encoding.
> .
>
I was thinking of it, but my reasoning under not doing so was that 
ARB_shader_bit_encoding is potentially usable even with GLSL 1.2 if to 
avoid unsigned integers, and I thought marking the extension disabled 
while it is actually enabled can be a bit obscure.