From: Józef Kucia Subject: Re: [PATCH] wined3d: Check GLSL version when using ARB_shader_bit_encoding with uvec4. Message-Id: Date: Fri, 19 Apr 2019 12:38:02 +0200 In-Reply-To: References: <20190418170649.27930-1-gofmanp@gmail.com> On Fri, Apr 19, 2019 at 12:35 PM Józef Kucia wrote: > > On Thu, Apr 18, 2019 at 7:07 PM Paul Gofman wrote: > > > > Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47039 > > > > There are GPUs which support ARB_shader_bit_encoding with GLSL > > version 1.2 and uvec4 data type is available since GLSL 1.3. > > Spotted with Intel Ironlake Mobile. > > > > Signed-off-by: Paul Gofman > > --- > > I'm not sure but I think that it could be preferred to disable > ARB_shader_bit_encoding when GLSL version < 1.30. We disable other > extensions conditionally in wined3d_adapter_init_gl_caps(), e.g. > ARB_shader_bit_encoding or ARB_shader_bit_encoding. I meant to use ARB_draw_indirect and ARB_texture_multisample as examples (I failed to copy & paste).