From: Andrew Eikum Subject: Re: [PATCH] mfc42: add static library Message-Id: <20190415151216.qmqoasvvxsouepzd@foghorn.codeweavers.com> Date: Mon, 15 Apr 2019 10:12:16 -0500 In-Reply-To: References: <5acdb643-a265-36a6-a989-b55f59ef9c2c@gmail.com> On Mon, Apr 15, 2019 at 06:14:43AM +0000, Jefferson Carpenter wrote: > As surprising as it is, merely having a DLL by the name of mfc42 > present, Rise of Legends is able to generate a PID after entering the > CD key. > I don't have any opinions on this patch, but Age of Empires 3 does the same thing. It loads mfc42, quits if it fails to load, and otherwise does nothing with it if it succeeds. It also complains about pidgen, so I guess it's some common anti-copy software. Andrew > On Mon, Apr 15, 2019 at 2:31 AM Austin English wrote: > > > > On Sun, Apr 14, 2019, 03:05 Jefferson Carpenter wrote: > >> > >> winetricks -q, rather. I'm not married to adding mfc42 if there's a > >> workaround that can be used instead. > >> > >> Sorry, I should have checked bugzilla first! > >> > >> On 4/14/2019 8:01 AM, Jefferson Carpenter wrote: > >> > Didn't check this first https://bugs.winehq.org/show_bug.cgi?id=657 > >> > > >> > However, the patch allows PidGen.dll referred to in the above bug to do > >> > its dirty work, which should remove a blockage from some games. > >> > > >> > The 'winetricks -w mfc42' workaround should still work even if Wine > >> > begins to implement mfc42. > >> > > >> > On 4/14/2019 6:08 AM, Austin English wrote: > >> >> On Sun, Apr 14, 2019, 01:05 Jefferson Carpenter < > >> >> jeffersoncarpenter2@gmail.com> wrote: > >> >> > >> >> What does this accomplish? I.e. how does it improve things over the > >> >> current > >> >> situation? > > > > > > > > Just because there's a workaround doesn't mean it shouldn't be fixed. > > > > The problem though is that it's completely undocumented. I don't think adding a stub with no exports that is unlikely to be implemented improves things over the status quo. > >