From: Thomas Faber <thomas.faber@reactos.org>
Subject: Re: [PATCH] gdi32: Reformat some strings to improve readability
Message-Id: <7da5399f-ec70-8b4f-3c80-41d98b8c3356@reactos.org>
Date: Sat, 13 Apr 2019 12:23:50 +0200
In-Reply-To: <87sgumjt8k.fsf@wine>
References: <20190401073518.27827-1-mstefani@winehq.org> <2f257bee-0bbf-0322-94a8-a8245cd258bb@codeweavers.com> <201cc9ef-1e69-2e98-7282-455c26e7ba8f@winehq.org> <87sgumjt8k.fsf@wine>

I was assuming the original patch was a joke due to the date, or I might 
have commented earlier. ;)

On 2019-04-13 08:48, Alexandre Julliard wrote:
> Michael Stefaniuc <mstefani@winehq.org> writes:
>> On 4/12/19 5:07 PM, Jacek Caban wrote:
>> The only known blocker is the mingw used on winehq.org to build the
>> winetest.exe.
>> As Alexandre works on the cross compile stuff I was hoping he'll have to
>> upgrade that one anyway.
> 
> Rather than converting everything over to u"", I'd prefer that we find
> ways to use L"".
> 
> For instance, I'm currently working on building more modules with
> MSVCRT, and converting them to use wchar functions instead of
> unicode.h. Such modules could be built with -fshort-wchar. Ultimately
> this would hopefully cover a large fraction of the code base.


For what it's worth, ReactOS uses GCC 4.7.2 and VC2010, neither of which 
support u"" (without an explicit -std=c11 anyway). I understand that's 
not exactly Wine's problem, and we'll find a way to work around it if 
necessary, just thought it might be an added data point.
L"" of course works fine, so I'm a strong proponent of using that for 
MinGW targets (or otherwise any solution that uses a macro over directly 
scattering u"" across the code base).


Thanks!
-Thomas