From: Gabriel Ivăncescu Subject: [PATCH 2/2] user32/combo: Don't redraw the Combo Box when dropped down if it has an editbox Message-Id: <059ff7f66cab7c4eff240b6955cf35416cbef882.1554725852.git.gabrielopcode@gmail.com> Date: Mon, 8 Apr 2019 15:19:47 +0300 In-Reply-To: <33038174a031806abb5826d52ede722330689c1c.1554725852.git.gabrielopcode@gmail.com> References: <33038174a031806abb5826d52ede722330689c1c.1554725852.git.gabrielopcode@gmail.com> Some applications subclass the combo box and handle WM_ERASEBKGND themselves, without using WS_CLIPCHILDREN. This causes them to erase over the editbox child. There's no reason to redraw it in this case since the editbox is supposed to cover it, anyway. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22260 Signed-off-by: Gabriel Ivăncescu --- dlls/user32/combo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c index 59c2e64..bd9a852 100644 --- a/dlls/user32/combo.c +++ b/dlls/user32/combo.c @@ -1051,7 +1051,7 @@ static void CBDropDown( LPHEADCOMBO lphc ) SWP_NOACTIVATE | SWP_SHOWWINDOW ); - if( !(lphc->wState & CBF_NOREDRAW) ) + if( !(lphc->wState & (CBF_NOREDRAW | CBF_EDIT)) ) RedrawWindow( lphc->self, NULL, 0, RDW_INVALIDATE | RDW_ERASE | RDW_UPDATENOW | RDW_NOCHILDREN ); -- 2.21.0