From: Vijay Kiran Kamuju <infyquest@gmail.com>
Subject: [PATCH v2] kernel32/tests: Add tests for FindFirstFileA with invalid characters.
Message-Id: <20190329235326.15652-1-infyquest@gmail.com>
Date: Sat, 30 Mar 2019 00:53:26 +0100

Includes testcases by Vincent Pelletier.
Mark some test as todo.

From: Michael Müller <michael@fds-team.de>

Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
---
 dlls/kernel32/tests/file.c | 81 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 80 insertions(+), 1 deletion(-)

diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c
index 33b17aa327..0d241df02e 100644
--- a/dlls/kernel32/tests/file.c
+++ b/dlls/kernel32/tests/file.c
@@ -2543,11 +2543,58 @@ static char get_windows_drive(void)
     return windowsdir[0];
 }
 
+struct
+{
+    const char *path;
+    BOOL expected;
+    BOOL todo;
+}
+static const invalid_char_tests[] =
+{
+    { "./test-dir",                     TRUE },
+    { "./test-dir/",                    FALSE },
+    { ".\\test-dir",                    TRUE },
+    { ".\\test-dir\\",                  FALSE },
+    { "/>test-dir",                     FALSE },
+    { "<\"test->dir",                   FALSE },
+    { "<test->dir",                     FALSE },
+    { "\"test-dir\"",                   FALSE },
+    { "\"test-file\"",                  FALSE },
+    { "test-/>dir",                     FALSE },
+    { "test-dir/",                      FALSE },
+    { "test-dir//",                     FALSE },
+    { "test-dir/:",                     FALSE },
+    { "test-dir/?",                     TRUE },
+    { "test-dir/*",                     TRUE },
+    { "test-dir/<",                     TRUE, TRUE },
+    { "test-dir/\"",                    TRUE, TRUE },
+    { "test-dir/\\",                    FALSE },
+    { "test-dir/|",                     FALSE },
+    { "test-dir<",                      TRUE, TRUE },
+    { "test-dir</",                     FALSE },
+    { "test-dir<<<><><>\"\"\"\"<<<>",   TRUE, TRUE },
+    { "test-dir>\"",                    TRUE, TRUE },
+    { "test-dir\"/",                    FALSE },
+    { "test-dir\"<",                    TRUE, TRUE },
+    { "test-dir\"\"",                   TRUE, TRUE },
+    { "test-dir\\/",                    FALSE },
+    { "test-dir\\\"",                   TRUE, TRUE },
+    { "test-dir\\\\",                   FALSE },
+    { "test-file/",                     FALSE },
+    { "test-file\\",                    FALSE },
+    { "test-file|",                     FALSE },
+    { "test-file?",                     TRUE, TRUE },
+    { "test-file*",                     TRUE },
+    { "test-file>",                     TRUE, TRUE },
+    { "test-file\"",                    TRUE, TRUE },
+    { "test-file\\",                    FALSE },
+};
+
 static void test_FindFirstFileA(void)
 {
     HANDLE handle;
     WIN32_FIND_DATAA data;
-    int err;
+    int err, i;
     char buffer[5] = "C:\\";
     char buffer2[100];
     char nonexistent[MAX_PATH];
@@ -2715,6 +2762,38 @@ static void test_FindFirstFileA(void)
     err = GetLastError();
     ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should fail\n", buffer2 );
     ok ( err == ERROR_PATH_NOT_FOUND, "Bad Error number %d\n", err );
+
+    /* try FindFirstFileA with invalid characters */
+    CreateDirectoryA("test-dir", NULL);
+    _lclose(_lcreat("test-file", 0));
+
+    for (i = 0; i < sizeof(invalid_char_tests) / sizeof(invalid_char_tests[0]); i++)
+    {
+        handle = FindFirstFileA(invalid_char_tests[i].path, &data);
+        if (invalid_char_tests[i].expected)
+        {
+            if (invalid_char_tests[i].todo)
+            {
+                todo_wine ok(handle != INVALID_HANDLE_VALUE, "FindFirstFileA on %s should succeed\n",
+                   invalid_char_tests[i].path);
+            }
+            else
+            {
+                ok(handle != INVALID_HANDLE_VALUE, "FindFirstFileA on %s should succeed\n",
+                   invalid_char_tests[i].path);
+            }
+        }
+        else
+        {
+                ok(handle == INVALID_HANDLE_VALUE, "FindFirstFileA on %s should fail\n",
+                   invalid_char_tests[i].path);
+        }
+        if (handle != INVALID_HANDLE_VALUE)
+            FindClose(handle);
+    }
+
+    DeleteFileA("test-file");
+    RemoveDirectoryA("test-dir");
 }
 
 static void test_FindNextFileA(void)

-- 
2.21.0