From: Alexandre Julliard Subject: Re: [PATCH 1/5] user32/tests: Add tests for GetWindowPlacement() and SetWindowPlacement(). Message-Id: <87mumz78c0.fsf@wine> Date: Wed, 13 Feb 2019 21:16:15 +0100 In-Reply-To: <76b75682-97e4-4117-11ff-d68ba8fc0e29@gmail.com> (Zebediah Figura's message of "Sun, 10 Feb 2019 23:35:21 -0600") References: <20190210190015.4039-1-z.figura12@gmail.com> <76b75682-97e4-4117-11ff-d68ba8fc0e29@gmail.com> Zebediah Figura writes: > On 2/10/19 1:39 PM, Marvin wrote: >> Hi, >> >> While running your changed tests on Windows, I think I found new failures. >> Being a bot and all I'm not very good at pattern recognition, so I might be >> wrong, but could you please double-check? >> >> Full results can be found at: >> https://testbot.winehq.org/JobDetails.pl?Key=47392 >> >> Your paranoid android. >> >> >> === wvistau64 (32 bit report) === >> >> user32: >> win.c:10796: Test failed: got minimized pos (0,713) >> win.c:10808: Test failed: got minimized pos (0,713) >> win.c:10820: Test failed: got minimized pos (0,713) >> win.c:10833: Test failed: got minimized pos (0,713) >> win.c:10846: Test failed: got minimized pos (0,713) >> win.c:10859: Test failed: got minimized pos (0,713) >> win.c:10872: Test failed: got minimized pos (0,713) >> win.c:10906: Test failed: got minimized pos (100,100) >> win.c:10928: Test failed: got minimized pos (100,100) >> > > *snip* > > This fails because test_shell_window(), which is pretty pathological, > kills explorer.exe, and that doesn't restart itself until the test > program terminates. What can be done about this, if anything? The obvious fix is to run your test before the one that kills the shell window. Though if the behavior depends on having a shell window, it may be interesting to test both cases. -- Alexandre Julliard julliard@winehq.org