From: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Subject: Re: [PATCH v2] windowscodecs/tests: Add IWICBitmapEncoderInfo test
Message-Id: <SLXP216MB0077736F6341E03CF983B69C93660@SLXP216MB0077.KORP216.PROD.OUTLOOK.COM>
Date: Wed, 13 Feb 2019 00:37:27 +0000
In-Reply-To: <CAAFPtVSUZwpuv16MDtEBpRgxa5mbyQr9XLWkCquMDxEd5270tA@mail.gmail.com>
References: <PS2P216MB0066A00BDCD508D45E6180E193640@PS2P216MB0066.KORP216.PROD.OUTLOOK.COM> <CAAFPtVSUZwpuv16MDtEBpRgxa5mbyQr9XLWkCquMDxEd5270tA@mail.gmail.com>

Hi Vincent,

Its intended behavior for XP and w2k3.

Here is a test run without the WINCODEC_ERR_COMPONENTNOTFOUND check.

https://testbot.winehq.org/JobDetails.pl?Key=47556


Alistair.

On 13/2/19 2:50 am, Vincent Povirk wrote:
> When is GetEncoderInfo expected to return
> WINCODEC_ERR_COMPONENTNOTFOUND? Is this an intended behavior, or a
> bug?
>
> On Sun, Feb 10, 2019 at 8:38 PM Alistair Leslie-Hughes
> <leslie_alistair@hotmail.com> wrote:
>> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
>> ---
>>   dlls/windowscodecs/tests/converter.c | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/dlls/windowscodecs/tests/converter.c b/dlls/windowscodecs/tests/converter.c
>> index 1cfa29b..72b625d 100644
>> --- a/dlls/windowscodecs/tests/converter.c
>> +++ b/dlls/windowscodecs/tests/converter.c
>> @@ -1217,6 +1217,8 @@ static void test_multi_encoder(const struct bitmap_data **srcs, const CLSID* cls
>>
>>           if (hglobal && SUCCEEDED(hr))
>>           {
>> +            IWICBitmapEncoderInfo *info;
>> +
>>               if (palette)
>>               {
>>                   hr = IWICBitmapEncoder_SetPalette(encoder, palette);
>> @@ -1233,6 +1235,20 @@ static void test_multi_encoder(const struct bitmap_data **srcs, const CLSID* cls
>>                   hr = S_OK;
>>               }
>>
>> +            hr = IWICBitmapEncoder_GetEncoderInfo(encoder, &info);
>> +            ok(hr == S_OK || hr == WINCODEC_ERR_COMPONENTNOTFOUND, "wrong error %#x\n", hr);
>> +            if (SUCCEEDED(hr))
>> +            {
>> +                CLSID clsid;
>> +
>> +                hr = IWICBitmapEncoderInfo_GetCLSID(info, &clsid);
>> +                ok(hr == S_OK, "wrong error %#x\n", hr);
>> +                ok(!IsEqualGUID(&clsid_encoder, &clsid), "wrong CLSID %s (%s)\n",
>> +                       wine_dbgstr_guid(clsid_encoder), wine_dbgstr_guid(&clsid));
>> +
>> +                IWICBitmapEncoderInfo_Release(info);
>> +            }
>> +
>>               i=0;
>>               while (SUCCEEDED(hr) && srcs[i])
>>               {
>> --
>> 1.9.1
>>
>>
>>