From: Jacek Caban <jacek@codeweavers.com>
Subject: Re: [PATCH] ieframe: Check FAILED in get_typeinfo().
Message-Id: <ab7b18db-9a29-5e16-4b33-9cf2630c0613@codeweavers.com>
Date: Tue, 12 Feb 2019 12:59:17 +0100
In-Reply-To: <20190211171540.13776-1-andrey.goosev@gmail.com>
References: <20190211171540.13776-1-andrey.goosev@gmail.com>

Hi Andrey,

On 2/11/19 6:15 PM, Andrey Gusev wrote:
> Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
> ---
>   dlls/ieframe/ieframe_main.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/dlls/ieframe/ieframe_main.c b/dlls/ieframe/ieframe_main.c
> index e207ce0575..ff7c1de306 100644
> --- a/dlls/ieframe/ieframe_main.c
> +++ b/dlls/ieframe/ieframe_main.c
> @@ -62,9 +62,7 @@ HRESULT get_typeinfo(tid_t tid, ITypeInfo **typeinfo)
>   {
>       HRESULT hres;
>   
> -    if(!typelib)
> -        hres = load_typelib();
> -    if(!typelib)
> +    if(FAILED(hres = load_typelib()))
>           return hres;
>   
>       if(!typeinfos[tid]) {


Skipping the first if means that you'd load typelib even if it's already 
loaded.


Jacek