From: Jacek Caban <jacek@codeweavers.com>
Subject: Re: [PATCH v2 2/2] vbscript: Allow GET, SET and LET to be used as id
Message-Id: <32ce3102-b169-e4b8-7222-340fecf8c422@codeweavers.com>
Date: Tue, 12 Feb 2019 12:56:56 +0100
In-Reply-To: <20190210004524.21594-2-brendan@redmandi.com>
References: <288c0b2d-0ac0-c953-b5d8-34559711b08b@codeweavers.com> <20190210004524.21594-1-brendan@redmandi.com> <20190210004524.21594-2-brendan@redmandi.com>

Hi Brendan,

On 2/10/19 1:45 AM, Brendan McGrath wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46318
> Signed-off-by: Brendan McGrath <brendan@redmandi.com>
> ---
> I took a look at the way jscript did this - but I couldn't work out how it
> was using '$1' as a value. So I ended up following the approach used for
> 'property'.


jscript can do that, because it declares tokens to have <identifier> 
type (see line 170 of its parser) and lexer returns appropriate value 
(see check_keywords lval handling). Anyway, I'd be fine with your 
version once it has proper tests.


BTW, it's probably a good idea to merge test and fix into one patch in 
this case.


> This meant I had to add a new constant definition for each keyword that
> could be used as an indentifier.As a result I went with a conservative
> approach and only added three more (in addition to 'property').


Conservative approach is fine and even preferred. Some of other keywords 
may cause parser conflicts, so we need to be careful about that.


Thanks,

Jacek