From: Michael Stefaniuc <mstefani@winehq.org>
Subject: Re: [PATCH v2] Add .editorconfig file
Message-Id: <7c9cc8d2-f5f9-ee22-5a05-b108e6ff83d3@winehq.org>
Date: Wed, 12 Dec 2018 21:28:16 +0100
In-Reply-To: <20181212091444.24829-1-eb1@sil.org>
References: <3912802.ognrodplc7@arch> <20181212091444.24829-1-eb1@sil.org>

Hello Eberhard,

tab_width needs to be 8. That's a given.
For exiting code the style of the surrounding code trumps. So the indent
and line length settings are just the recommendations for new code but
not necessary true for all files in Wine.

The important question though is:
What will the editors / IDE do with this file?
Will they automatically start to re-indent the whole file being edited
if they see .editorconfig?
That would be counterproductive as unrelated whitespace changes are not
allowed. Of course fixing whitespace issues in modified lines is wanted
and sometimes even expected, depending on the subsystem maintainer.

bye
	michael


On 12/12/18 10:14 AM, Eberhard Beilharz wrote:
> This allows editors and IDEs to automatically adjust settings to
> the coding style prefered by Wine (cf. https://editorconfig.org/).
> 
> Signed-off-by: Eberhard Beilharz <eb1@sil.org>
> ---
>  .editorconfig | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 .editorconfig
> 
> diff --git a/.editorconfig b/.editorconfig
> new file mode 100644
> index 0000000000..71dc8633f8
> --- /dev/null
> +++ b/.editorconfig
> @@ -0,0 +1,11 @@
> +root = true
> +
> +# Defaults
> +[*]
> +indent_style = space
> +indent_size = 4
> +tab_width = 4
> +charset = utf-8
> +trim_trailing_whitespace = true
> +insert_final_newline = false
> +max_line_length = 100
>