From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH v3 2/6] wined3d: Add flag to indicate FETCH4 support in textures
Message-Id: <CAOsNvwzqC4+ydzaAtCqLbJ_1zgqHQEpdAtSe9QurZx66CnTFiw@mail.gmail.com>
Date: Tue, 27 Nov 2018 23:02:12 +0330
In-Reply-To: <20181124201337.20330-2-mailszeros@gmail.com>
References: <20181122012823.15966-1-mailszeros@gmail.com> <20181124201337.20330-1-mailszeros@gmail.com> <20181124201337.20330-2-mailszeros@gmail.com>

On Sat, 24 Nov 2018 at 23:44, Daniel Ansorregui <mailszeros@gmail.com> wrote:
> @@ -340,6 +340,18 @@ static const struct wined3d_format_base_flags format_base_flags[] =
>      {WINED3DFMT_NULL,                 WINED3DFMT_FLAG_EXTENSION},
>      {WINED3DFMT_NVDB,                 WINED3DFMT_FLAG_EXTENSION},
>      {WINED3DFMT_RESZ,                 WINED3DFMT_FLAG_EXTENSION},
> +    {WINED3DFMT_L8_UNORM,             WINED3DFMT_FLAG_ALLOW_FETCH4},
> +    {WINED3DFMT_L16_UNORM,            WINED3DFMT_FLAG_ALLOW_FETCH4},
> +    {WINED3DFMT_R16,                  WINED3DFMT_FLAG_ALLOW_FETCH4},
> +    {WINED3DFMT_R32_FLOAT,            WINED3DFMT_FLAG_ALLOW_FETCH4},
One of the rules/guidelines we have in Wine is that we try to avoid
dead code. This patch runs into that because it sets a flag that isn't
used until the following patch in the series. Since both patches
aren't especially large, the best thing to do would probably be to
just merge them.

> +
> +    /* The formats below are not tested to be FETCH4 compatible on windows but
> +     * the spec "hints" that depth formats are not recomended (but allowed) */
That should be easy to test, right?