From: Fabian Maurer Subject: Re: [PATCH] find: First simple implementation and tests Message-Id: <5872049.ertVgER7FE@arch> Date: Sun, 23 Sep 2018 16:26:09 +0200 In-Reply-To: <6203369.9FyhP8A9iY@arch> References: <20180915154246.8132-1-dark.shadow4@web.de> <8e7fe51f-d844-1519-183b-56d357cf9bd5@codeweavers.com> <6203369.9FyhP8A9iY@arch> For some reason it cut off my mail... I tried using ReadConsoleW to make things easier, but that doesn't work with redirected console handles. So I have to do it with ReadFile. I also planned to use that function to read from an handle for reading line-by-line from files, too. reg uses GetConsoleOutputCP, which would break the tests I wrote for find - so I can't really use that either. Question is, is mine still a bad approach, what'd you suggest? Regards, Fabian Maurer

For some reason it cut off my mail...

 

I tried using ReadConsoleW to make things easier, but that doesn't work with redirected console handles. So I have to do it with ReadFile. I also planned to use that function to read from an handle for reading line-by-line from files, too.

 

reg uses GetConsoleOutputCP, which would break the tests

I wrote for find - so I can't really use that either.

 

Question is, is mine still a bad approach, what'd you suggest?

 

 

Regards,

Fabian Maurer