From: Alexandre Julliard Subject: Re: [PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure Message-Id: <87fty2hqe7.fsf@winehq.org> Date: Fri, 21 Sep 2018 16:33:04 +0200 In-Reply-To: ("Gabriel Ivăncescu"'s message of "Fri, 21 Sep 2018 17:03:34 +0300") References: <4416482679d9bcb58a14dcd706aa40bec582bbe3.1537444354.git.gabrielopcode@gmail.com> <20180921105531.GP3601@merlot.physics.ox.ac.uk> <20180921113841.GR3601@merlot.physics.ox.ac.uk> <20180921120240.GU3601@merlot.physics.ox.ac.uk> <20180921134315.GW3601@merlot.physics.ox.ac.uk> <87lg7vgdhb.fsf@winehq.org> Gabriel Ivăncescu writes: > On Fri, Sep 21, 2018 at 4:57 PM, Alexandre Julliard wrote: >> Huw Davies writes: >> >>> On Fri, Sep 21, 2018 at 03:38:39PM +0300, Gabriel Ivăncescu wrote: >>>> On Fri, Sep 21, 2018 at 3:02 PM, Huw Davies wrote: >>>> > >>>> > As I hinted at above, unless you can type very much faster than me >>>> > then I don't consider this much of an issue. >>>> >>>> Well it's not much of an issue but it's still a slight improvement for >>>> the wineserver to have to process less in its queue, and all it needs >>>> is change a few lines (4 in total) from SendMessage to CallWindowProc. >>>> >>>> Are you sure you don't want me to do that? >>> >>> Yes. >>> >>> It may only be 4 lines, but it's a reasonably fundamental change to >>> how things work which will require time to review and add to the >>> possibility of regressions. So if it's not actually improving >>> things in a noticable manner then it should stay out. >> >> Not to mention that SendMessage doesn't do a wineserver call for the >> thread-local case, so it's not even improving anything. >> >> -- >> Alexandre Julliard >> julliard@winehq.org > > Yeah but it's not the SendMessage that's the wineserver call I'm > talking about, but the fact that it will go through this subclassed > window procedure again (it starts at the top), which ends up calling > GetPropW to get the This pointer just to forward it to the edit > control. As I see, GetPropW uses a wineserver call. If it turns out that GetPropW is a bottleneck (very unlikely), it can be optimized in various ways. Please don't obfuscate the code in an attempt to make things faster where it doesn't matter. -- Alexandre Julliard julliard@winehq.org