From: Alexandre Julliard Subject: Re: [PATCH v2 5/8] shell32/autocomplete: Send messages directly to the edit control's procedure Message-Id: <87lg7vgdhb.fsf@winehq.org> Date: Fri, 21 Sep 2018 15:57:20 +0200 In-Reply-To: <20180921134315.GW3601@merlot.physics.ox.ac.uk> (Huw Davies's message of "Fri, 21 Sep 2018 14:43:15 +0100") References: <4416482679d9bcb58a14dcd706aa40bec582bbe3.1537444354.git.gabrielopcode@gmail.com> <20180921105531.GP3601@merlot.physics.ox.ac.uk> <20180921113841.GR3601@merlot.physics.ox.ac.uk> <20180921120240.GU3601@merlot.physics.ox.ac.uk> <20180921134315.GW3601@merlot.physics.ox.ac.uk> Huw Davies writes: > On Fri, Sep 21, 2018 at 03:38:39PM +0300, Gabriel Ivăncescu wrote: >> On Fri, Sep 21, 2018 at 3:02 PM, Huw Davies wrote: >> > >> > As I hinted at above, unless you can type very much faster than me >> > then I don't consider this much of an issue. >> >> Well it's not much of an issue but it's still a slight improvement for >> the wineserver to have to process less in its queue, and all it needs >> is change a few lines (4 in total) from SendMessage to CallWindowProc. >> >> Are you sure you don't want me to do that? > > Yes. > > It may only be 4 lines, but it's a reasonably fundamental change to > how things work which will require time to review and add to the > possibility of regressions. So if it's not actually improving > things in a noticable manner then it should stay out. Not to mention that SendMessage doesn't do a wineserver call for the thread-local case, so it's not even improving anything. -- Alexandre Julliard julliard@winehq.org