From: Huw Davies <huw@codeweavers.com>
Subject: Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters
Message-Id: <20180921114426.GS3601@merlot.physics.ox.ac.uk>
Date: Fri, 21 Sep 2018 12:44:26 +0100
In-Reply-To: <CA+rRCMKgBrs4FKvDZJV6UJDZrjDnBwLpewesJvZj=cbaiTq69A@mail.gmail.com>
References: <d0e97ff7a9dca16c6c9c3bffa9720f460de0001e.1537444354.git.gabrielopcode@gmail.com> <0d9f77e0aa067a3883af70444ae00efa535bc668.1537444354.git.gabrielopcode@gmail.com> <34e55051-197e-e84a-bfa4-6844e3c37506@codeweavers.com> <CA+rRCMKYXea=OYUE6r5f3Bb7qi4DcjkQL=AxPx2gXzaLfca3Ag@mail.gmail.com> <20180921104522.GO3601@merlot.physics.ox.ac.uk> <CA+rRCMJm_zGpy6XHzm8Gpos878sJK5UZf82=i_F48HPonQQQUw@mail.gmail.com> <20180921113206.GQ3601@merlot.physics.ox.ac.uk> <CA+rRCMKgBrs4FKvDZJV6UJDZrjDnBwLpewesJvZj=cbaiTq69A@mail.gmail.com>

On Fri, Sep 21, 2018 at 02:39:12PM +0300, Gabriel Ivăncescu wrote:
> On Fri, Sep 21, 2018 at 2:32 PM, Huw Davies <huw@codeweavers.com> wrote:
> >
> > How many exceptions (to iscntrlW()) do you actually need?
> >
> > Huw.
> 
> Well Backspace for sure, maybe Tab (if it's inserted in an edit
> control, don't know if that's possible), same doubt about newlines
> ('\n' and '\r') or "vertical tab" (are those valid in certain edit
> controls?).
> 
> I mean if anything '\b' has to be an exception, at the very least. The
> rest can be ignored I guess, if you want to simplify this to just one
> check for '\b' instead. Should I just check for backspace?

Doesn't sound like it would be too hard to test (just send some WM_CHARs
to the edit).

Huw.