From: Gabriel Ivăncescu Subject: Re: [PATCH v2 4/8] shell32/autocomplete: Don't autocomplete at all on most control characters Message-Id: Date: Thu, 20 Sep 2018 18:54:28 +0300 In-Reply-To: <34e55051-197e-e84a-bfa4-6844e3c37506@codeweavers.com> References: <0d9f77e0aa067a3883af70444ae00efa535bc668.1537444354.git.gabrielopcode@gmail.com> <34e55051-197e-e84a-bfa4-6844e3c37506@codeweavers.com> On Thu, Sep 20, 2018 at 3:51 PM, Nikolay Sivov wrote: > Maybe filter with iscntrlW() with exceptions? > > I only tried to avoid most of the CTRL+something control characters. I see iscntrlW deals with Unicode table (probably some unicode-specific control chars as well). So I think the current method has less implications, but that depends on my understanding of it. Do you think it's a better approach with iscntrlW? (and keep the range between \b and \r then as the exceptions?). Unfortunately it would still look like a semi-hack due to the exceptions which are needed, at least for backspace and maybe tab. Not sure if it's better honestly.