From: Jacek Caban Subject: Re: [PATCH] wininet/tests: Don't check certificate when secure flag is not set Message-Id: <536c7f1d-3d1f-c7e1-e95b-41c7e727af51@codeweavers.com> Date: Tue, 18 Sep 2018 14:45:04 +0200 In-Reply-To: <74b7aeff-1e00-0f74-028e-a172974def83@dawncrow.de> References: <4e17a36a-1628-81f8-38cb-257acc98068c@dawncrow.de> <74b7aeff-1e00-0f74-028e-a172974def83@dawncrow.de> Hi André, On 09/18/2018 02:09 PM, André Hentschel wrote: > On 17.09.2018 16:55, Jacek Caban wrote: >> Hi André, >> >> On 09/15/2018 02:47 PM, André Hentschel wrote: >>> Signed-off-by: André Hentschel >>> --- >>>   dlls/wininet/tests/http.c | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c >>> index ace8512399..8bc06b9166 100644 >>> --- a/dlls/wininet/tests/http.c >>> +++ b/dlls/wininet/tests/http.c >>> @@ -6025,7 +6025,8 @@ static void test_secure_connection(void) >>>       ok(ret, "InternetQueryOption failed: %d\n", GetLastError()); >>>       ok(flags & SECURITY_FLAG_SECURE, "expected secure flag to be >>> set\n"); >>>   -    test_cert_struct(req, &test_winehq_org_cert); >>> +    if (flags & SECURITY_FLAG_SECURE) >>> +        test_cert_struct(req, &test_winehq_org_cert); >> >> What do you want to achieve with this patch? Note that we test the flag >> just before test_cert_struct call, so tests will fail with your patch >> anyway. >> >> Jacek >> > > Hi Jacek, > > I should have mentioned that it's supposed to fix the crash in newer > win10 versions: > https://test.winehq.org/data/8a985174ebc1b041d9a4f1abbdc184fe692d25bf/index_Win10.html#wininet:http > Still, there will be failures, so it's not much better. Ideally we'd find why it fails. Those are not testbot machines, so it's hard to experiment with them... I can see a value in avoiding the crash. This way we'd see how other https-related tests behave and maybe have more information that would help us find the actual problem. For that, however, I'd suggest to return early from test_cert_struct when InternetQueryOptionA fails. Thanks, Jacek