From: Nikolay Sivov <nsivov@codeweavers.com>
Subject: Re: [PATCH] scrrun: Add MoveFile().
Message-Id: <8e995d39-554e-5e06-5ee1-b509dd6e5026@codeweavers.com>
Date: Sun, 16 Sep 2018 17:06:07 +0300
In-Reply-To: <1801392.9NKejRn9qR@arch>
References: <20180916130147.19829-1-nsivov@codeweavers.com> <1801392.9NKejRn9qR@arch>

On 09/16/2018 04:48 PM, Fabian Maurer wrote:

> > + TRACE("%p %s %s\n", iface, debugstr_w(src), debugstr_w(dest));
>
> > +
>
> > + if (MoveFileW(src, dest))
>
> > + return S_OK;
>
> > +
>
> > + error = GetLastError();
>
> > + switch (error)
>
> > + {
>
> > + case ERROR_ALREADY_EXISTS:
>
> > + return CTL_E_FILEALREADYEXISTS;
>
> > + case ERROR_FILE_NOT_FOUND:
>
> > + return CTL_E_FILENOTFOUND;
>
> > + default:
>
> > + return HRESULT_FROM_WIN32(error);
>
> > + }
>
> That doesn't seem quite correct.
>
> As the docs I linked from 
> https://bugs.winehq.org/show_bug.cgi?id=45839 state, this function 
> also accepts wildcards. On my win7 machine that works, but MoveFileW 
> can't handle this.
>

Should still work for reported case. I can add a warning with arguments 
for error case if you think it helps.

> Regards,
>
> Fabian Maurer
>