From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH 1/2] d2d1: Implement GetSurface() for bitmaps.
Message-Id: <CAOsNvww4K7qr2R6d-+6T5t6oRSXTB=BPcAtgwJDsF9BHO-yNNg@mail.gmail.com>
Date: Fri, 14 Sep 2018 19:45:17 +0430
In-Reply-To: <20180914055030.9103-1-nsivov@codeweavers.com>
References: <20180914055030.9103-1-nsivov@codeweavers.com>

On 14 September 2018 at 10:20, Nikolay Sivov <nsivov@codeweavers.com> wrote:
> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
> ---
>  dlls/d2d1/bitmap.c       | 69 ++++++++++++++++++++++++----------------
>  dlls/d2d1/d2d1_private.h | 12 +++++--
>  dlls/d2d1/device.c       |  9 ++----
>  dlls/d2d1/tests/d2d1.c   | 63 ++++++++++++++++++++----------------
>  4 files changed, 90 insertions(+), 63 deletions(-)
>
This seems a little more complicated than it really needs to be. In
d2d_bitmap_GetSurface(), can't you just do something like the
following?

    ID3D10ShaderResourceView_GetResource(bitmap->view, &resource);
    ID3D10Resource_QueryInterface(resource, &IID_IDXGISurface, &surface);