From: Józef Kucia <joseph.kucia@gmail.com>
Subject: Re: [PATCH 4/5] wined3d: Add shadow sampler capability bit to d3d_info.
Message-Id: <CAKF0LCVvj=L8NX8akA3OVvdZ2-oGPwvq5sfH=V6dY6OCyjZ1jg@mail.gmail.com>
Date: Fri, 24 Aug 2018 15:47:11 +0200
In-Reply-To: <CAOsNvwxtR1M9bU715WV6_SqrXjBWf8ycS_A--i4Phd0CuSuw+g@mail.gmail.com>
References: <20180823123406.3523-4-jkucia@codeweavers.com> <CAOsNvwxtR1M9bU715WV6_SqrXjBWf8ycS_A--i4Phd0CuSuw+g@mail.gmail.com>

On Thu, Aug 23, 2018 at 7:42 PM Henri Verbeet <hverbeet@gmail.com> wrote:
>
> On 23 August 2018 at 17:04, Józef Kucia <jkucia@codeweavers.com> wrote:
> > Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
> > ---
> >  dlls/wined3d/adapter_gl.c      | 1 +
> >  dlls/wined3d/directx.c         | 2 +-
> >  dlls/wined3d/wined3d_private.h | 6 +++++-
> >  3 files changed, 7 insertions(+), 2 deletions(-)
> >
> I'm not necessarily against this, but strictly speaking the
> "shadow_sampler" field is somewhat superfluous. I think we simply
> shouldn't be setting the WINED3DFMT_FLAG_TEXTURE flag if ARB_shadow
> isn't supported, in which case wined3d_check_device_format() could
> lose the special case.

It should be possible to not set the WINED3DFMT_FLAG_TEXTURE flag, but
it's a bit more invasive change. I'll take a look.