From: Henri Verbeet <hverbeet@gmail.com>
Subject: Re: [PATCH 4/5] wined3d: Add shadow sampler capability bit to d3d_info.
Message-Id: <CAOsNvwxtR1M9bU715WV6_SqrXjBWf8ycS_A--i4Phd0CuSuw+g@mail.gmail.com>
Date: Thu, 23 Aug 2018 22:11:53 +0430
In-Reply-To: <20180823123406.3523-4-jkucia@codeweavers.com>
References: <20180823123406.3523-4-jkucia@codeweavers.com>

On 23 August 2018 at 17:04, Józef Kucia <jkucia@codeweavers.com> wrote:
> Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
> ---
>  dlls/wined3d/adapter_gl.c      | 1 +
>  dlls/wined3d/directx.c         | 2 +-
>  dlls/wined3d/wined3d_private.h | 6 +++++-
>  3 files changed, 7 insertions(+), 2 deletions(-)
>
I'm not necessarily against this, but strictly speaking the
"shadow_sampler" field is somewhat superfluous. I think we simply
shouldn't be setting the WINED3DFMT_FLAG_TEXTURE flag if ARB_shadow
isn't supported, in which case wined3d_check_device_format() could
lose the special case.