From: Huw Davies Subject: Re: [PATCH] gdi32: Add a workaround for A->W text output with Symbol font encoding. Message-Id: <20180622103901.GA19488@merlot.physics.ox.ac.uk> Date: Fri, 22 Jun 2018 11:39:03 +0100 In-Reply-To: <20180622125506.4c1f369b2387cd95fc69c200@baikal.ru> References: <20180622125506.4c1f369b2387cd95fc69c200@baikal.ru> On Fri, Jun 22, 2018 at 12:55:06PM +0800, Dmitry Timoshkov wrote: > There are 2 ways to output Ansi text: > 1. Call DrawTextA/ExtTextOutA, it uses font codepage for unicode translation. > 2. hfont = CreateFont("Wingdings", SYMBOL_CHARSET); > SendMessageA(hwnd, WM_SETFONT, hfont); > SendMessageA(hwnd, WM_SETTEXT, textA); > It uses current ANSI codepage for unicode translation. > > Currently #1 works correctly for Symbol fonts but #2 does not. This patch > makes #2 work as well. Since this is a text drawing bug I don't see a way > of adding a test case for this behaviour. Looks good. I've sent in a new version with a re-worded commit message that hopefully makes it clear that this isn't a work-around in Wine, but a work-around in Windows. I also fixed a grammar issue in an existing comment and took the opportunity to make the formatting more consistent. Huw.