From: Henri Verbeet Subject: Re: [PATCH 2/2] d2d1: Add ID2D1DeviceContext stub. Message-Id: Date: Tue, 29 May 2018 12:31:23 +0430 In-Reply-To: <20180526064717.14023-2-nsivov@codeweavers.com> References: <20180526064717.14023-1-nsivov@codeweavers.com> <20180526064717.14023-2-nsivov@codeweavers.com> On 26 May 2018 at 11:17, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov > --- > dlls/d2d1/device.c | 784 ++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 782 insertions(+), 2 deletions(-) > > diff --git a/dlls/d2d1/device.c b/dlls/d2d1/device.c > index 67b3fab906..63941dca3d 100644 > --- a/dlls/d2d1/device.c > +++ b/dlls/d2d1/device.c > @@ -38,11 +38,23 @@ struct d2d_draw_text_layout_ctx > D2D1_DRAW_TEXT_OPTIONS options; > }; > > +struct d2d_device_context > +{ > + ID2D1DeviceContext ID2D1DeviceContext_iface; > + LONG refcount; > + struct d2d_device *device; > +}; > + Since ID2D1DeviceContext extends ID2D1RenderTarget, should this implementation really be separate from the d2d_d3d_render_target implementation?