From: Lucian Poston <lucianposton@pm.me>
Subject: Re: [PATCH 5/6] dwrite: Use MapCharacters for non-visual characters
Message-Id: <Kn5bzLJQNjh_pLWhp0Bv6BCr75jyje5HNc5gtTW2rwWUp_Rz_hMoRtnEMcdaC51ZX9Fjh8A9ABjhzSfBXqLbSH3JfhyUWLJAaYAlcdG9d6c=@pm.me>
Date: Sat, 26 May 2018 10:01:42 -0400
In-Reply-To: <5d409192-1497-5846-a3a4-969ef60370aa@codeweavers.com>
References: <YGwSF45X9D6NRVBOoqMgcepKvjtHMBblux2mNyntFdg8y8GJWLTQIuzIweenLTKoZk9Rkd_AWwghuLB7J4TxMvxc_LwCal6TJT40_R3WEPk=@pm.me> <E4DTU7iuXuM3KljgEMiIOtEh9SEJib70L0-sNpjUk5vDJdRWaptlu3PtYso1o8u_r-er1NP4m5-7Uox4LexmbXBW9WFrUsBtWGfqxGkpX7Y=@pm.me> <5d409192-1497-5846-a3a4-969ef60370aa@codeweavers.com>

On Sat, May 26, 2018 at 06:43:39AM -0700, Nikolay Sivov wrote:
> This only works together with patch 4/6, right?

Yes. Some of the fixed tests in 5/6 will fail without 4/6 applied before this
one.

> What we need to figure 
> out here is which font is picked in NO_VISUAL case, does it change with 
> range locale,
> or custom collection. Then we can either hardcode it here, or add 
> corresponding char ranges.

Going from memory, it was tahoma in win 10 (without custom collection), but I
suspect that comes from the system font collection or system fontfallback
object.

I don't know if you'd want to hardcode it here. The fontfallback allows you
define a mapping between char ranges and font, so the system's fontfallback
would seem like the appropriate place for that.