From: Andrew Eikum <aeikum@codeweavers.com>
Subject: Re: [PATCH v2 5/5] winegstreamer: Use ERR instead of FIXME for GStreamer errors.
Message-Id: <20180222171318.zutdwudncnny3xw2@foghorn.codeweavers.com>
Date: Thu, 22 Feb 2018 11:13:18 -0600
In-Reply-To: <1519311977-13458-5-git-send-email-z.figura12@gmail.com>
References: <1519311977-13458-1-git-send-email-z.figura12@gmail.com> <1519311977-13458-5-git-send-email-z.figura12@gmail.com>

Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>

On Thu, Feb 22, 2018 at 09:06:17AM -0600, Zebediah Figura wrote:
> Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
> ---
>  dlls/winegstreamer/gstdemux.c    | 8 ++++----
>  dlls/winegstreamer/gsttffilter.c | 4 ++--
>  dlls/winegstreamer/main.c        | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
> index 518d995..0ce92a4 100644
> --- a/dlls/winegstreamer/gstdemux.c
> +++ b/dlls/winegstreamer/gstdemux.c
> @@ -1079,8 +1079,8 @@ static GstBusSyncReply watch_bus(GstBus *bus, GstMessage *msg, gpointer data)
>  
>      if (GST_MESSAGE_TYPE(msg) & GST_MESSAGE_ERROR) {
>          gst_message_parse_error(msg, &err, &dbg_info);
> -        FIXME("%s: %s\n", GST_OBJECT_NAME(msg->src), err->message);
> -        WARN("%s\n", dbg_info);
> +        ERR("%s: %s\n", GST_OBJECT_NAME(msg->src), err->message);
> +        ERR("%s\n", dbg_info);
>      } else if (GST_MESSAGE_TYPE(msg) & GST_MESSAGE_WARNING) {
>          gst_message_parse_warning(msg, &err, &dbg_info);
>          WARN("%s: %s\n", GST_OBJECT_NAME(msg->src), err->message);
> @@ -1095,7 +1095,7 @@ static GstBusSyncReply watch_bus(GstBus *bus, GstMessage *msg, gpointer data)
>  static void unknown_type(GstElement *bin, GstPad *pad, GstCaps *caps, gpointer user)
>  {
>      gchar *strcaps = gst_caps_to_string(caps);
> -    FIXME("Could not find a filter for caps: %s\n", strcaps);
> +    ERR("Could not find a filter for caps: %s\n", strcaps);
>      g_free(strcaps);
>  }
>  
> @@ -1126,7 +1126,7 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
>  
>      gstfilter = gst_element_factory_make("decodebin", NULL);
>      if (!gstfilter) {
> -        FIXME("Could not make source filter, are gstreamer-plugins-* installed for %u bits?\n",
> +        ERR("Could not make source filter, are gstreamer-plugins-* installed for %u bits?\n",
>                8 * (int)sizeof(void*));
>          return E_FAIL;
>      }
> diff --git a/dlls/winegstreamer/gsttffilter.c b/dlls/winegstreamer/gsttffilter.c
> index 401a92f..29e679b 100644
> --- a/dlls/winegstreamer/gsttffilter.c
> +++ b/dlls/winegstreamer/gsttffilter.c
> @@ -111,7 +111,7 @@ static const char *Gstreamer_FindMatch(const char *strcaps)
>      g_list_free(copy);
>  
>      if (!bestfactory) {
> -        FIXME("Could not find plugin for %s\n", strcaps);
> +        ERR("Could not find plugin for %s\n", strcaps);
>          return NULL;
>      }
>      return gst_plugin_feature_get_name(GST_PLUGIN_FEATURE(bestfactory));
> @@ -312,7 +312,7 @@ static HRESULT Gstreamer_transform_ConnectInput(GstTfImpl *This, const AM_MEDIA_
>  
>      This->filter = gst_element_factory_make(This->gstreamer_name, NULL);
>      if (!This->filter) {
> -        FIXME("Could not make %s filter\n", This->gstreamer_name);
> +        ERR("Could not make %s filter\n", This->gstreamer_name);
>          return E_FAIL;
>      }
>      This->my_src = gst_pad_new("yuvsrc", GST_PAD_SRC);
> diff --git a/dlls/winegstreamer/main.c b/dlls/winegstreamer/main.c
> index 2bb69f4..dc988cf 100644
> --- a/dlls/winegstreamer/main.c
> +++ b/dlls/winegstreamer/main.c
> @@ -276,7 +276,7 @@ DWORD Gstreamer_init(void)
>          inited = gst_init_check(&argc, &argv, &err);
>          HeapFree(GetProcessHeap(), 0, argv);
>          if (err) {
> -            FIXME("Failed to initialize gstreamer: %s\n", err->message);
> +            ERR("Failed to initialize gstreamer: %s\n", err->message);
>              g_error_free(err);
>          }
>          if (inited) {
> -- 
> 2.7.4
> 
> 
>