From: Zebediah Figura <z.figura12@gmail.com>
Subject: Re: [PATCH 1/5] winegstreamer: Stop creating the filter if gstreamer fails to render.
Message-Id: <30927db1-4ba5-81a0-9eec-0105d32cdb55@gmail.com>
Date: Thu, 22 Feb 2018 09:06:36 -0600
In-Reply-To: <20180222141822.jneauwunmcp4uaxp@foghorn.codeweavers.com>
References: <1519179182-627-1-git-send-email-z.figura12@gmail.com> <20180222141822.jneauwunmcp4uaxp@foghorn.codeweavers.com>

On 22/02/18 08:18, Andrew Eikum wrote:
> On Tue, Feb 20, 2018 at 08:12:58PM -0600, Zebediah Figura wrote:
>> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
>> index a19c64f..ea61ed5 100644
>> --- a/dlls/winegstreamer/gstdemux.c
>> +++ b/dlls/winegstreamer/gstdemux.c
>> @@ -1165,7 +1164,7 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
>>  
>>      if (!This->cStreams) {
>>          FIXME("GStreamer could not find any streams\n");
>> -        hr = E_FAIL;
>> +        return E_FAIL;
>>      } else {
>>          gst_pad_query_duration(This->ppPins[0]->their_src, GST_FORMAT_TIME, &duration);
>>          for (i = 0; i < This->cStreams; ++i) {
> 
> Would you mind removing the now-redundant else here? All of the other
> patches look good to me.
> 
> Thanks,
> Andrew
> 
> 

Thanks, resent.