From: Nikolay Sivov Subject: [PATCH 1/3] oleaut32: Don't reset property page site to NULL Message-Id: <20180222115837.8654-1-nsivov@codeweavers.com> Date: Thu, 22 Feb 2018 14:58:35 +0300 Signed-off-by: Nikolay Sivov --- Fixes the crash reported as https://bugs.winehq.org/show_bug.cgi?id=44265. There is another patch attached to this bug that allows to manually test creation/destruction sequence. dlls/oleaut32/olepropframe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dlls/oleaut32/olepropframe.c b/dlls/oleaut32/olepropframe.c index 73af7451f1..1a89024885 100644 --- a/dlls/oleaut32/olepropframe.c +++ b/dlls/oleaut32/olepropframe.c @@ -308,10 +308,8 @@ HRESULT WINAPI OleCreatePropertyFrameIndirect(LPOCPFIPARAMS lpParams) PropertySheetW(&property_sheet); for(i=0; icPages; i++) { - if(property_page[i]) { - IPropertyPage_SetPageSite(property_page[i], NULL); + if(property_page[i]) IPropertyPage_Release(property_page[i]); - } } HeapFree(GetProcessHeap(), 0, dialogs); -- 2.16.1