From: Станислав Мотыльков Subject: Re: [PATCH 1/1] rasapi32: Add stub for RasGetConnectionStatistics Message-Id: Date: Wed, 22 Nov 2017 21:19:21 +0300 In-Reply-To: References: Indeed, that change in header file was done by Sebastian Lackner, he accepted my patch in Wine Staging: https://dev.wine-staging.com/patches/203/ Attached my updated patch. Also can you advice whether this is ok to send patch that already was submitted to Wine Staging, should I wait for it or it is normal to go forward? Regards, Stas'M. On 11/22/17, Alex Henrie wrote: > 2017-11-22 6:33 GMT-07:00 Станислав Мотыльков : >> This patch allows to run some programs that require this API -- >> without it they can't start. Don't know whether there are existing >> bug-reports in Wine referring this, but there's open bug report in >> ReactOS project tracker: >> https://jira.reactos.org/browse/CORE-10426 > > OK. There are still two more problems. First, the patch does not compile: > > rasapi.c: In function ‘RasGetConnectionStatistics’: > rasapi.c:554:12: error: ‘ERROR_UNKNOWN’ undeclared (first use in this > function); did you mean ‘DRIVE_UNKNOWN’? > return ERROR_UNKNOWN; > ^~~~~~~~~~~~~ > DRIVE_UNKNOWN > > It looks like you forgot to include the change to raserror.h that was > included in your Wine Staging patch: > https://github.com/wine-compholio/wine-staging/blob/master/patches/rasapi32-RasGetConnectionStatistics/0001-rasapi32-Add-stub-for-RasGetConnectionStatistics.patch > > Second, you need to include a Signed-off-by line in your commit > message. See https://wiki.winehq.org/Submitting_Patches#The_commit_message > > -Alex > From 8cb902b407afef95cac06fbc52c42d5e481a610a Mon Sep 17 00:00:00 2001 From: Stanislav Motylkov Date: Wed, 4 Oct 2017 23:46:35 +0300 Subject: rasapi32: Add stub for RasGetConnectionStatistics Fixes https://jira.reactos.org/browse/CORE-10426 Signed-off-by: Stanislav Motylkov --- dlls/rasapi32/rasapi.c | 6 ++++++ dlls/rasapi32/rasapi32.spec | 1 + include/raserror.h | 1 + 3 files changed, 8 insertions(+) diff --git a/dlls/rasapi32/rasapi.c b/dlls/rasapi32/rasapi.c index b1721c61752..791b0dab133 100644 --- a/dlls/rasapi32/rasapi.c +++ b/dlls/rasapi32/rasapi.c @@ -547,3 +547,9 @@ DWORD WINAPI RasGetLinkStatistics(HRASCONN connection, DWORD entry, RAS_STATS *s FIXME("(%p,%u,%p), stub!\n", connection, entry, statistics); return 0; } + +DWORD WINAPI RasGetConnectionStatistics(HRASCONN connection, RAS_STATS *statistics) +{ + FIXME("(%p,%p), stub!\n", connection, statistics); + return ERROR_UNKNOWN; +} diff --git a/dlls/rasapi32/rasapi32.spec b/dlls/rasapi32/rasapi32.spec index 66b21a657cc..48d7a73dc87 100644 --- a/dlls/rasapi32/rasapi32.spec +++ b/dlls/rasapi32/rasapi32.spec @@ -29,6 +29,7 @@ @ stdcall RasGetAutodialEnableW(long ptr) @ stdcall RasGetAutodialParamA(long ptr ptr) @ stdcall RasGetAutodialParamW(long ptr ptr) +@ stdcall RasGetConnectionStatistics(ptr ptr) @ stub RasGetConnectResponse @ stdcall RasGetConnectStatusA(ptr ptr) @ stdcall RasGetConnectStatusW(ptr ptr) diff --git a/include/raserror.h b/include/raserror.h index 17359368780..549b42423cf 100644 --- a/include/raserror.h +++ b/include/raserror.h @@ -23,6 +23,7 @@ #define ERROR_BUFFER_TOO_SMALL (RASBASE+3) #define ERROR_BUFFER_INVALID (RASBASE+10) #define ERROR_INVALID_SIZE (RASBASE+32) +#define ERROR_UNKNOWN (RASBASE+35) #define ERROR_STATE_MACHINES_NOT_STARTED (RASBASE+95) #define ERROR_RASMAN_CANNOT_INITIALIZE (RASBASE+111) -- 2.14.1