From: Alex Henrie <alexhenrie24@gmail.com>
Subject: Re: [PATCH 1/1] rasapi32: Add stub for RasGetConnectionStatistics
Message-Id: <CAMMLpeQbmEUnCjJA00x_OYHSh3f2Q-N8pWD7eevOMGu=pa8=pA@mail.gmail.com>
Date: Wed, 22 Nov 2017 09:31:53 -0700
In-Reply-To: <CAAD2TPbyievBpS6-7_-BO+uuXR4vgegFECgr37cJhPa-JM2sLA@mail.gmail.com>
References: <CAAD2TPY7kmp_pvE397GMpc3qx2kQKM2mRLGrAK8iLdXf-Q9qbQ@mail.gmail.com> <CAMMLpeROrzsj+yU9zKDR2s6YchbiL8XNG_3r1KfUee-__JdQmw@mail.gmail.com> <CAAD2TPbyievBpS6-7_-BO+uuXR4vgegFECgr37cJhPa-JM2sLA@mail.gmail.com>

2017-11-22 6:33 GMT-07:00 Станислав Мотыльков <x86corez@gmail.com>:
> This patch allows to run some programs that require this API --
> without it they can't start. Don't know whether there are existing
> bug-reports in Wine referring this, but there's open bug report in
> ReactOS project tracker:
> https://jira.reactos.org/browse/CORE-10426

OK. There are still two more problems. First, the patch does not compile:

rasapi.c: In function ‘RasGetConnectionStatistics’:
rasapi.c:554:12: error: ‘ERROR_UNKNOWN’ undeclared (first use in this
function); did you mean ‘DRIVE_UNKNOWN’?
     return ERROR_UNKNOWN;
            ^~~~~~~~~~~~~
            DRIVE_UNKNOWN

It looks like you forgot to include the change to raserror.h that was
included in your Wine Staging patch:
https://github.com/wine-compholio/wine-staging/blob/master/patches/rasapi32-RasGetConnectionStatistics/0001-rasapi32-Add-stub-for-RasGetConnectionStatistics.patch

Second, you need to include a Signed-off-by line in your commit
message. See https://wiki.winehq.org/Submitting_Patches#The_commit_message

-Alex