From: Dmitry Timoshkov Subject: Re: [PATCH 02/10] taskschd: Implement ITaskSettings_put_RestartCount. Message-Id: <20171122222036.52e7072a3b5a2ee02f6f85da@baikal.ru> Date: Wed, 22 Nov 2017 22:20:36 +0800 In-Reply-To: <20171122140839.13140-2-hans@codeweavers.com> References: <20171122140839.13140-2-hans@codeweavers.com> Hans Leidekker wrote: > static HRESULT WINAPI TaskSettings_put_RestartInterval(ITaskSettings *iface, BSTR interval) > { > + TaskSettings *taskset = impl_from_ITaskSettings(iface); > + BSTR str = NULL; > + > TRACE("%p,%s\n", iface, debugstr_w(interval)); > - return E_NOTIMPL; > + > + if (interval && !(str = SysAllocString(interval))) return E_OUTOFMEMORY; > + SysFreeString(taskset->restart_interval); > + taskset->restart_interval = str; > + > + return S_OK; > } This set of patches is a little bit messed up. The subject doesn't reflect actual patch contents for multiple patches in the set. Could you please fix the patches? -- Dmitry.