From: Paul Gofman Subject: [v5 1/3] d3dx9: Remove redundant parameter size check in set_constants(). Message-Id: <20170622131156.18171-1-gofmanp@gmail.com> Date: Thu, 22 Jun 2017 16:11:54 +0300 Signed-off-by: Paul Gofman --- v5: - Removed assert for parameter data length. The check for constant size not exceeding parameter size is in the next patch. Otherwise the code would be changed right in the next patch after modifying get_const_upload_info(), while before that the check is redundant. --- dlls/d3dx9_36/preshader.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c index 7ca0c8f..3b06f66 100644 --- a/dlls/d3dx9_36/preshader.c +++ b/dlls/d3dx9_36/preshader.c @@ -1181,11 +1181,6 @@ static void set_constants(struct d3dx_regstore *rs, struct d3dx_const_tab *const param_offset = i + j * info.major; else param_offset = i * info.minor + j; - if (param_offset * sizeof(unsigned int) >= param->bytes) - { - WARN("Parameter data is too short, name %s, component %u.\n", debugstr_a(param->name), i); - break; - } out[offset] = data[param_offset]; } } -- 2.9.4