From: Francois Gouget Subject: [Tools v2 2/2] winetest/dissect: Remove some pointless sprintfs. Message-Id: <3c72aec5acce3e8557710eb02de1e09e10885955.1490270424.git.fgouget@codeweavers.com> Date: Thu, 23 Mar 2017 13:02:14 +0100 (CET) In-Reply-To: <94abec4edd19970c2d8dfdec72a1d268bf4fbb11.1490270424.git.fgouget@codeweavers.com> References: <94abec4edd19970c2d8dfdec72a1d268bf4fbb11.1490270424.git.fgouget@codeweavers.com> Signed-off-by: Francois Gouget --- winetest/dissect | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/winetest/dissect b/winetest/dissect index c6b4b71..d8fc7cf 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -130,9 +130,9 @@ $_ = ; my $box = create_box( "version", "version", "Version information for $tag" ); $box->{data} .= "

Build version

\n"; $box->{data} .= "\n"; -$box->{data} .= sprintf "\n", $testbuild, $testbuild, $shortbuild; +$box->{data} .= "\n"; $box->{data} .= "
Build%s
Build$shortbuild
Tag$tag
\n"; -$box->{data} .= sprintf "
\n"; +$box->{data} .= "
\n"; while (($_ = ) =~ s/^ //) { chomp; @@ -301,7 +301,7 @@ while () { } if ($3 eq "skipped") { - $testbox->{data} .= sprintf "
Skipped by user request.
\n"; + $testbox->{data} .= "
Skipped by user request.
\n"; print SUM "- $dll $unit skipped - - - $source $rev\n"; $dll = undef; mydie "too many tests skipped by user request\n" if ++$user_skips > $maxuserskips; @@ -428,7 +428,7 @@ for (my $i = 0; $i <= $#boxes; $i++) printf REPORT "
\n", $boxes[$i]->{title}; printf REPORT "\n", $boxes[$i]->{prev} if defined $boxes[$i]->{prev}; printf REPORT "\n", $boxes[$i]->{next} if defined $boxes[$i]->{next}; - printf REPORT "
%s
\n"; + print REPORT "\n"; print REPORT $boxes[$i]->{data}, "\n"; } print REPORT end_html(); -- 2.11.0