From: Sebastian Lackner <sebastian@fds-team.de>
Subject: Re: [PATCH] hidclass.sys: Use IoSetCompletionRoutine
Message-Id: <5657dd33-1d94-b9c3-ba76-2b61c7fcaa01@fds-team.de>
Date: Tue, 18 Oct 2016 17:40:26 +0200
In-Reply-To: <ad2973b2-0b89-7f30-e966-82f5ee7bf2be@codeweavers.com>
References: <ad2973b2-0b89-7f30-e966-82f5ee7bf2be@codeweavers.com>

On 18.10.2016 17:07, Aric Stewart wrote:
> Signed-off-by: Aric Stewart <aric@codeweavers.com>
> ---
>  dlls/hidclass.sys/device.c | 20 +++++++-------------
>  dlls/hidclass.sys/main.c   | 13 +++++--------
>  dlls/hidclass.sys/pnp.c    | 10 +++++-----
>  3 files changed, 17 insertions(+), 26 deletions(-)

Thanks! While you are just at it, could you please also check the two
occurances of "if (irp->IoStatus.u.Status == STATUS_PENDING)"? They
look wrong to me, the correct way would be to check the return value
of IoCallDriver. Also, it looks like call_minidriver is leaking "buffer".

Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>