From: Aaryaman Vasishta Subject: Re: Add a GUI for dxdiag program Message-Id: Date: Sat, 27 Aug 2016 15:01:57 +0530 In-Reply-To: <57c1550a.11092e0a.17169.26e8@mx.google.com> References: <57c1550a.11092e0a.17169.26e8@mx.google.com> Hi, Thanks for your patch! I see there are still many style inconsistencies here, like "foo=bar;" and "foo = bar;" mixed together. Same for passing arguments, like "foo(bar,baz)" and "foo(bar, baz)" mixed together. Please try sticking to a single convention, it helps in code readability. There also might be an issue with the consistency of indendation on longer lines which do not fit. As long as you keep the indentation levels consistent across the file you should be fine. On Sat, Aug 27, 2016 at 1:56 PM, Ruslan Kabatsayev wrote: > +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam, > LPARAM lparam) > +{ > + switch(msg) > + { > + case WM_COMMAND: > + switch(HIWORD(wparam)) > + { > + case BN_CLICKED: > + switch(wparam) > + { > + case IDC_WHQL_CHECKBOX: > + { > + update_dxdiag_info(); > + return TRUE; > + } > + } > + break; > There's an indentation issue here. You should still wait for others to review this before re-sending this patch though. Cheers, Aaryaman

Hi,

Thanks for your patch!

I see there are still many style inconsistencies here, like "foo=bar;" and "foo = bar;" mixed together. Same for passing arguments, like "foo(bar,baz)" and "foo(bar, baz)" mixed together. Please try sticking to a single convention, it helps in code readability. There also might be an issue with the consistency of indendation on longer lines which do not fit. As long as you keep the indentation levels consistent across the file you should be fine.

On Sat, Aug 27, 2016 at 1:56 PM, Ruslan Kabatsayev <b7.10110111@gmail.com> wrote:

+INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam, LPARAM lparam)
+{
+ switch(msg)
+ {
+ case WM_COMMAND:
+ switch(HIWORD(wparam))
+ {
+ case BN_CLICKED:
+ switch(wparam)
+ {
+ case IDC_WHQL_CHECKBOX:
+ {
+ update_dxdiag_info();
+ return TRUE;
+ }
+ }
+ break;

There's an indentation issue here.

You should still wait for others to review this before re-sending this patch though.

Cheers,

Aaryaman