From: Andrew Eikum <aeikum@codeweavers.com>
Subject: Re: [PATCH] qedit: Remove redundant "return 0" from Release functions.
Message-Id: <20160429133047.GV31257@foghorn.codeweavers.com>
Date: Fri, 29 Apr 2016 08:30:47 -0500
In-Reply-To: <1461820406-18718-1-git-send-email-alexhenrie24@gmail.com>
References: <1461820406-18718-1-git-send-email-alexhenrie24@gmail.com>

Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>

On Wed, Apr 27, 2016 at 11:12:54PM -0600, Alex Henrie wrote:
> Cc: Andrew Eikum <aeikum@codeweavers.com>
> Cc: Nikolay Sivov <nsivov@codeweavers.com>
> 
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  dlls/qedit/mediadet.c      | 1 -
>  dlls/qedit/samplegrabber.c | 2 --
>  dlls/qedit/timeline.c      | 3 ---
>  3 files changed, 6 deletions(-)
> 
> diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c
> index 53ab75a..b7a5abb 100644
> --- a/dlls/qedit/mediadet.c
> +++ b/dlls/qedit/mediadet.c
> @@ -112,7 +112,6 @@ static ULONG WINAPI MediaDet_inner_Release(IUnknown *iface)
>      {
>          MD_cleanup(This);
>          CoTaskMemFree(This);
> -        return 0;
>      }
>  
>      return ref;
> diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c
> index 946dba9..e3f387b 100644
> --- a/dlls/qedit/samplegrabber.c
> +++ b/dlls/qedit/samplegrabber.c
> @@ -92,7 +92,6 @@ static ULONG WINAPI Single_IEnumMediaTypes_Release(IEnumMediaTypes *iface)
>          if (This->mtype.pbFormat)
>              CoTaskMemFree(This->mtype.pbFormat);
>          CoTaskMemFree(This);
> -        return 0;
>      }
>      return refCount;
>  }
> @@ -335,7 +334,6 @@ static ULONG WINAPI SampleGrabber_Release(IUnknown *iface)
>      {
>          SampleGrabber_cleanup(This);
>          CoTaskMemFree(This);
> -        return 0;
>      }
>      return ref;
>  }
> diff --git a/dlls/qedit/timeline.c b/dlls/qedit/timeline.c
> index 8c6ac5b..450e796 100644
> --- a/dlls/qedit/timeline.c
> +++ b/dlls/qedit/timeline.c
> @@ -103,10 +103,7 @@ static ULONG WINAPI Timeline_Release(IUnknown *iface)
>      TRACE("(%p) new ref = %u\n", This, ref);
>  
>      if (ref == 0)
> -    {
>          CoTaskMemFree(This);
> -        return 0;
> -    }
>  
>      return ref;
>  }
> -- 
> 2.8.0
>