From: Sergey Isakov Subject: Fix warning: logical not is only applied to the left hand side of this comparison Message-Id: Date: Thu, 26 Nov 2015 23:49:11 +0300 Thanks Bruno for the critics. Now I rebase the patches to recent wine-1.8-rc1-89-g4a315cd and split them to separate commits. Now only two files because third is already corrected. Thanks Bruno for the critics.

Now I rebase the patches to recent wine-1.8-rc1-89-g4a315cd

and split them to separate commits.

Now only two files because third is already corrected.

commit e9d277b082bce01de83f191f24310f22188615b7 Author: Sergey Isakov Date: Thu Nov 26 23:39:39 2015 +0300 msi/tests: Simplify the logic in a if condition Signed-off-by: Sergey Isakov diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index a1df3f1..d02e9a2 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -878,7 +878,7 @@ static HRESULT invoke(IDispatch *pDispatch, LPCSTR szName, WORD wFlags, DISPPARA hr = IDispatch_GetIDsOfNames(pDispatch, &IID_NULL, &name, 1, LOCALE_USER_DEFAULT, &dispid); HeapFree(GetProcessHeap(), 0, name); ok(hr == S_OK, "IDispatch::GetIDsOfNames returned 0x%08x\n", hr); - if (!hr == S_OK) return hr; + if (hr != S_OK) return hr; memset(&excepinfo, 0, sizeof(excepinfo)); hr = IDispatch_Invoke(pDispatch, dispid, &IID_NULL, LOCALE_NEUTRAL, wFlags, pDispParams, pVarResult, &excepinfo, NULL);

commit ed98df1038742648930765a34a59f13d850dc7eb Author: Sergey Isakov Date: Thu Nov 26 23:44:52 2015 +0300 tapi32: Simplify the logic in an if condition Signed-off-by: Sergey Isakov diff --git a/dlls/tapi32/assisted.c b/dlls/tapi32/assisted.c index 9e68a5c..0d707db 100644 --- a/dlls/tapi32/assisted.c +++ b/dlls/tapi32/assisted.c @@ -60,7 +60,7 @@ DWORD WINAPI tapiGetLocationInfoW(LPWSTR countrycode, LPWSTR citycode) 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\', 'T','e','l','e','p','h','o','n','y','\\','L','o','c','a','t','i','o','n','s',0}; - if(!RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey) != ERROR_SUCCESS) { + if(RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey) == ERROR_SUCCESS) { valsize = sizeof( DWORD); if(!RegQueryValueExW(hkey, currentidW, 0, &type, (LPBYTE) &currid, &valsize) && type == REG_DWORD) {