From: Nikolay Sivov Subject: [PATCH] winex11: Simplify XGetWindowProperty return code checks (Clang) Message-Id: <1448486933-28573-1-git-send-email-nsivov@codeweavers.com> Date: Thu, 26 Nov 2015 00:28:53 +0300 Signed-off-by: Nikolay Sivov --- Two cases are about if (!call() != Success) style, third one for consistency with the rest of winex11.drv. dlls/winex11.drv/clipboard.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c index 842ebfe..5dc5e3c 100644 --- a/dlls/winex11.drv/clipboard.c +++ b/dlls/winex11.drv/clipboard.c @@ -2448,7 +2448,7 @@ static int X11DRV_CLIPBOARD_QueryAvailableData(Display *display) /* Read the TARGETS property contents */ if (!XGetWindowProperty(display, xe.xselection.requestor, xe.xselection.property, 0, 0x3FFF, True, AnyPropertyType/*XA_ATOM*/, &atype, &aformat, &cSelectionTargets, - &remain, (unsigned char**)&targetList) != Success) + &remain, (unsigned char**)&targetList)) { TRACE("Type %lx,Format %d,nItems %ld, Remain %ld\n", atype, aformat, cSelectionTargets, remain); @@ -2583,7 +2583,7 @@ static BOOL X11DRV_CLIPBOARD_GetProperty(Display *display, Window w, Atom prop, for (;;) { if (XGetWindowProperty(display, w, prop, pos, INT_MAX / 4, False, - AnyPropertyType, atype, &aformat, &nitems, &remain, &buffer) != Success) + AnyPropertyType, atype, &aformat, &nitems, &remain, &buffer)) { WARN("Failed to read property\n"); HeapFree( GetProcessHeap(), 0, val ); @@ -3354,7 +3354,7 @@ static Atom X11DRV_SelectionRequest_MULTIPLE( HWND hWnd, XSelectionRequestEvent if (!XGetWindowProperty(display, pevent->requestor, rprop, 0, 0x3FFF, False, AnyPropertyType, &atype,&aformat, &cTargetPropList, &remain, - (unsigned char**)&targetPropList) != Success) + (unsigned char**)&targetPropList)) { if (TRACE_ON(clipboard)) { -- 2.6.2