From: "Olivier F. R. Dierick" Subject: [1/2] kernel32: K32EnumProcessModules: Fail gracefully with NULL pointer and size > 0 Message-Id: <1435803802.27092.46.camel@piezo3.piezo-forte.be> Date: Thu, 02 Jul 2015 04:23:22 +0200 Supersedes patch with submission ID 112500. Addresses bug 38841. Former patch introduce a regression in dlls/psapi/tests. K32EnumProcessModules must fail when lphModule is NULL *and* cb is greater than 0. Also made the code more compact. --- dlls/kernel32/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Olivier F. R. Dierick o.dierick@piezo-forte.be From aa370ae372ada13b34783eadbc768215424b22c7 Mon Sep 17 00:00:00 2001 From: "Olivier F. R. Dierick" Date: Thu, 2 Jul 2015 03:00:18 +0200 Subject: K32EnumProcessModules: Fail gracefully with NULL pointer and size > 0 --- dlls/kernel32/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index f495e81..dac66c1 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -1226,7 +1226,7 @@ BOOL WINAPI K32EnumProcessModules(HANDLE process, HMODULE *lphModule, if (!init_module_iterator(&iter, process)) return FALSE; - if (!needed) + if ((cb && !lphModule) || !needed) { SetLastError(ERROR_NOACCESS); return FALSE; -- 1.7.10.4