From: Jacek Caban Subject: mshtml: Initialize output value before passing it to VariantCopy. Message-Id: <55549320.5050303@codeweavers.com> Date: Thu, 14 May 2015 14:20:48 +0200 --- dlls/mshtml/htmlevent.c | 1 + dlls/mshtml/tests/events.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 6468b38..037010e 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -482,6 +482,7 @@ static HRESULT WINAPI HTMLEventObj_get_returnValue(IHTMLEventObj *iface, VARIANT TRACE("(%p)->(%p)\n", This, p); + V_VT(p) = VT_EMPTY; return VariantCopy(p, &This->return_value); } diff --git a/dlls/mshtml/tests/events.c b/dlls/mshtml/tests/events.c index 11a91da..1874e80 100644 --- a/dlls/mshtml/tests/events.c +++ b/dlls/mshtml/tests/events.c @@ -1078,7 +1078,7 @@ static HRESULT WINAPI submit_onclick_setret(IDispatchEx *iface, DISPID id, LCID ok(hres == S_OK, "put_returnValue failed: %08x\n", hres); IHTMLEventObj_Release(event); - V_VT(&v) = VT_ERROR; + V_VT(&v) = 0xdead; hres = IHTMLEventObj_get_returnValue(event, &v); ok(hres == S_OK, "get_returnValue failed: %08x\n", hres); ok(VarCmp(&v, &onclick_event_retval, 0, 0) == VARCMP_EQ, "unexpected returnValue\n");