From: Piotr Caban <piotr@codeweavers.com>
Subject: shell32: Handle TRASH_EnumItems failures correctly
Message-Id: <54C775B1.4060206@codeweavers.com>
Date: Tue, 27 Jan 2015 12:25:37 +0100

---
  dlls/shell32/recyclebin.c       | 13 +++++++++++--
  dlls/shell32/tests/recyclebin.c | 21 +++++++++++----------
  2 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/dlls/shell32/recyclebin.c b/dlls/shell32/recyclebin.c
index d839329..d1a116e 100644
--- a/dlls/shell32/recyclebin.c
+++ b/dlls/shell32/recyclebin.c
@@ -860,10 +860,14 @@ HRESULT WINAPI SHQueryRecycleBinW(LPCWSTR pszRootPath, LPSHQUERYRBINFO pSHQueryR
     LPITEMIDLIST *apidl;
     INT cidl;
     INT i=0;
+    HRESULT hr;
+
     TRACE("(%s, %p)\n", debugstr_w(pszRootPath), pSHQueryRBInfo);
     FIXME("Ignoring pszRootPath=%s\n",debugstr_w(pszRootPath));
 
-    TRASH_EnumItems(&apidl,&cidl);
+    hr = TRASH_EnumItems(&apidl,&cidl);
+    if (FAILED(hr))
+        return hr;
     pSHQueryRBInfo->i64NumItems = cidl;
     pSHQueryRBInfo->i64Size = 0;
     for (; i<cidl; i++)
@@ -894,9 +898,14 @@ HRESULT WINAPI SHEmptyRecycleBinW(HWND hwnd, LPCWSTR pszRootPath, DWORD dwFlags)
     INT cidl;
     INT i=0;
     HRESULT ret;
+
     TRACE("(%p, %s, 0x%08x)\n", hwnd, debugstr_w(pszRootPath) , dwFlags);
     FIXME("Ignoring pszRootPath=%s\n",debugstr_w(pszRootPath));
-    TRASH_EnumItems(&apidl,&cidl);
+
+    ret = TRASH_EnumItems(&apidl,&cidl);
+    if (FAILED(ret))
+        return ret;
+
     ret = erase_items(hwnd,(const LPCITEMIDLIST*)apidl,cidl,!(dwFlags & SHERB_NOCONFIRMATION));
     for (;i<cidl;i++)
         ILFree(apidl[i]);
diff --git a/dlls/shell32/tests/recyclebin.c b/dlls/shell32/tests/recyclebin.c
index d449b7e..5c21761 100644
--- a/dlls/shell32/tests/recyclebin.c
+++ b/dlls/shell32/tests/recyclebin.c
@@ -72,9 +72,12 @@ static void test_query_recyclebin(void)
     strcat(buf,name);
     buf[strlen(buf) + 1] = '\0';
     hr = pSHQueryRecycleBinA(buf,&info1);
-    ok(hr == S_OK, "SHQueryRecycleBinA failed with error 0x%x\n", hr);
-    ok(info1.i64Size!=0xdeadbeef,"i64Size not set\n");
-    ok(info1.i64NumItems!=0xdeadbeef,"i64NumItems not set\n");
+    if(hr != S_OK) todo_wine ok(hr == S_OK, "SHQueryRecycleBinA failed with error 0x%x\n", hr);
+    else {
+        ok(hr == S_OK, "SHQueryRecycleBinA failed with error 0x%x\n", hr);
+        ok(info1.i64Size!=0xdeadbeef,"i64Size not set\n");
+        ok(info1.i64NumItems!=0xdeadbeef,"i64NumItems not set\n");
+    }
     /*create and send a file to the recycle bin*/
     file = CreateFileA(name,GENERIC_WRITE,0,NULL,CREATE_ALWAYS,0,NULL);
     ok(file != INVALID_HANDLE_VALUE, "Failure to open file %s\n",name);
@@ -89,13 +92,11 @@ static void test_query_recyclebin(void)
     shfo.lpszProgressTitle = NULL;
     ok(!pSHFileOperationA(&shfo), "Deletion was not successful\n");
     hr = pSHQueryRecycleBinA(buf,&info2);
-    ok(hr == S_OK, "SHQueryRecycleBinW failed with error 0x%x\n", hr);
-    if(info2.i64Size!=info1.i64Size || info2.i64NumItems!=info1.i64NumItems) {
-      ok(info2.i64Size==info1.i64Size+written,"Expected recycle bin to have 0x%s bytes\n",str_from_int64(info1.i64Size+written));
-      ok(info2.i64NumItems==info1.i64NumItems+1,"Expected recycle bin to have 0x%s items\n",str_from_int64(info1.i64NumItems+1));
-    } else todo_wine {
-      ok(info2.i64Size==info1.i64Size+written,"Expected recycle bin to have 0x%s bytes\n",str_from_int64(info1.i64Size+written));
-      ok(info2.i64NumItems==info1.i64NumItems+1,"Expected recycle bin to have 0x%s items\n",str_from_int64(info1.i64NumItems+1));
+    if(hr != S_OK) todo_wine ok(hr == S_OK, "SHQueryRecycleBinA failed with error 0x%x\n", hr);
+    else {
+        ok(hr == S_OK, "SHQueryRecycleBinA failed with error 0x%x\n", hr);
+        ok(info2.i64Size==info1.i64Size+written,"Expected recycle bin to have 0x%s bytes\n",str_from_int64(info1.i64Size+written));
+        ok(info2.i64NumItems==info1.i64NumItems+1,"Expected recycle bin to have 0x%s items\n",str_from_int64(info1.i64NumItems+1));
     }
 }