From: Bruno Jesus <00cpxxx@gmail.com> Subject: msi: Remove duplicate if condition Message-Id: Date: Fri, 24 Oct 2014 15:09:27 -0200 This was introduced in http://source.winehq.org/git/wine.git/commitdiff/5aac1ec6 There are identical "(!lstrcmpW(szProperty, INSTALLPROPERTY_LOCALPACKAGEW))" conditions. I'm removing the second one. The first condition is at https://source.winehq.org/source/dlls/msi/msi.c#1754 Fixes https://bugs.winehq.org/show_bug.cgi?id=37119 diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 70a8134..433776d 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -1762,10 +1762,6 @@ UINT WINAPI MsiGetPatchInfoExW(LPCWSTR szPatchCode, LPCWSTR szProductCode, datakey = patch; szProperty = szInstalled; } - else if (!strcmpW( szProperty, INSTALLPROPERTY_LOCALPACKAGEW )) - { - datakey = udpatch; - } else if (!strcmpW( szProperty, INSTALLPROPERTY_UNINSTALLABLEW ) || !strcmpW( szProperty, INSTALLPROPERTY_PATCHSTATEW ) || !strcmpW( szProperty, INSTALLPROPERTY_DISPLAYNAMEW ) ||