From: Austin English <austinenglish@gmail.com>
Subject: Re: server: KeyNameInformation returns the full name of the key. (try 3)
Message-Id: <CACC5Q1er_AWzs-NR9fbZa0BUg_6CDFahHC4B81q7rEqUnnaVVQ@mail.gmail.com>
Date: Thu, 16 Oct 2014 16:24:41 -0500

On Mon, Oct 13, 2014 at 10:25 AM, Akihiro Sagawa <sagawa.aki@gmail.com>
wrote:

> Try 3:
>   - Avoid allocating memory. (Based on Alexandre's comment, thanks.)
>   - Use k != root_key instead of k->namelen != 0.
>   - Add insufficient buffer test.
>
> ---
>  dlls/ntdll/tests/reg.c | 19 ++++++++++++++-----
>  server/registry.c      | 25 ++++++++++++++++++++++++-
>  2 files changed, 38 insertions(+), 6 deletions(-)
>

Hi Akihiro,

This change breaks the tests on my machine (causing wineserver to crash and
the ntdll/reg test to fail), see
https://bugs.winehq.org/show_bug.cgi?id=37411

Could you please take a look?

Thanks,
-Austin

<div dir="ltr">On Mon, Oct 13, 2014 at 10:25 AM, Akihiro Sagawa <span dir="ltr">&lt;<a href="mailto:sagawa.aki@gmail.com" target="_blank">sagawa.aki@gmail.com</a>&gt;</span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>Try 3:<br>
  - Avoid allocating memory. (Based on Alexandre&#39;s comment, thanks.)<br>
  - Use k != root_key instead of k-&gt;namelen != 0.<br>
  - Add insufficient buffer test.<br>
<br>
---<br>
 dlls/ntdll/tests/reg.c | 19 ++++++++++++++-----<br>
 server/registry.c      | 25 ++++++++++++++++++++++++-<br>
 2 files changed, 38 insertions(+), 6 deletions(-)<br></div></blockquote><div><br></div><div>Hi Akihiro,<br><br></div><div>This change breaks the tests on my machine (causing wineserver to crash and the ntdll/reg test to fail), see <a href="https://bugs.winehq.org/show_bug.cgi?id=37411">https://bugs.winehq.org/show_bug.cgi?id=37411</a><br><br>Could you please take a look?<br><br>Thanks,<br></div></div>-Austin
</div></div>