From: Jacek Caban Subject: ieframe: Don't crash if output parameter is NULL in WebBrowser::get_RegisterAsDropTarget. Message-Id: <5433A2DB.7050609@codeweavers.com> Date: Tue, 07 Oct 2014 10:22:51 +0200 --- dlls/ieframe/tests/webbrowser.c | 4 ++++ dlls/ieframe/webbrowser.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c index 5973900..fa37169 100644 --- a/dlls/ieframe/tests/webbrowser.c +++ b/dlls/ieframe/tests/webbrowser.c @@ -2321,6 +2321,10 @@ static void test_ie_funcs(IWebBrowser2 *wb) ok(sName!=NULL, "get_Name return a NULL string.\n"); SysFreeString(sName); + /* RegisterAsDropTarget */ + hres = IWebBrowser2_get_RegisterAsDropTarget(wb, NULL); + ok(hres == E_INVALIDARG, "get_RegisterAsDropTarget returned: %08x\n", hres); + /* Quit */ hres = IWebBrowser2_Quit(wb); diff --git a/dlls/ieframe/webbrowser.c b/dlls/ieframe/webbrowser.c index a3233e1..1f58bbb 100644 --- a/dlls/ieframe/webbrowser.c +++ b/dlls/ieframe/webbrowser.c @@ -943,7 +943,12 @@ static HRESULT WINAPI WebBrowser_get_RegisterAsDropTarget(IWebBrowser2 *iface, VARIANT_BOOL *pbRegister) { WebBrowser *This = impl_from_IWebBrowser2(iface); + FIXME("(%p)->(%p)\n", This, pbRegister); + + if(!pbRegister) + return E_INVALIDARG; + *pbRegister=0; return S_OK; }