From: Hans Leidekker Subject: winhttp: Verify the async parameter type in IWinHttpRequest::Open. Message-Id: <1410791804.16815.2.camel@t400> Date: Mon, 15 Sep 2014 16:36:44 +0200 --- dlls/winhttp/request.c | 2 +- dlls/winhttp/tests/winhttp.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 1f9b4aa..d497d7a 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -2992,7 +2992,7 @@ static HRESULT WINAPI winhttp_request_Open( path[uc.dwUrlPathLength + uc.dwExtraInfoLength] = 0; if (!(verb = strdupW( method ))) goto error; - if (V_BOOL( &async )) flags |= WINHTTP_FLAG_ASYNC; + if (V_VT( &async ) == VT_BOOL && V_BOOL( &async )) flags |= WINHTTP_FLAG_ASYNC; if (!(hsession = WinHttpOpen( user_agentW, WINHTTP_ACCESS_TYPE_DEFAULT_PROXY, NULL, NULL, flags ))) { err = get_last_error(); diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 27bb540..ce538fd 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -2561,6 +2561,8 @@ static void test_IWinHttpRequest(void) method = SysAllocString( method1W ); SysFreeString( url ); url = SysAllocString( url1W ); + V_VT( &async ) = VT_ERROR; + V_ERROR( &async ) = DISP_E_PARAMNOTFOUND; hr = IWinHttpRequest_Open( req, method, url, async ); ok( hr == S_OK, "got %08x\n", hr ); -- 2.1.0